Sidebar filtering tests and fixes #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpkane
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.21.3 #3280 +/- ##
================================================
Coverage 15.41% 15.42%
================================================
Files 564 564
Lines 69658 69626 -32
Branches 667 667
================================================
Hits 10739 10739
+ Misses 58919 58887 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This was referenced Jul 11, 2023
benjaminpkane
added a commit
that referenced
this pull request
Jul 12, 2023
* Refactor schemaControls, use selectField() when searching, cleaner schema documentation selection mode is default now for filed visibility * update count dependency to refelct when applying filter rules * add documentation links * better disable field handling - (un)select is broken - fixing next * improve select all control * uncheck subpaths even if they are disabled * show embedded document in selection mode * field doc type using tertiary text color * minor tweaks in color modal title style * review comments and fix include nested fields selection view * review comments, refactor selection row, and count fix * add first vitest for visibility, upgrade vitest packages * add basic test and refactor more * keep one embed doc field * no coverage when yarn test * add support for multi-select with string type * adds a Docker Hub Pulls badge * Typo * tweaking * lint * Add files via upload * Update brain.rst * Update index.rst * Update index.rst * Update index.rst * Update index.rst * Release v0.21.2 (#3251) (#3255) * update sidebar test, fix small regressions (#3250) * remove next index ref, fix string filter is matching default (#3249) * release notes * package bumps * disabled e2e * lint * fix mac arm64 * Teams v1.3.2 release note * rm e2e * add main * add icon * typo * first pass at milvus integration docs * adding milvus to user_guide/brain * adding to integrations index * adding milvus logo * square image, lower resolution * editing pass * consistency * bugfixes * disable field unit testing * group and video dataset unit tests disabled * toPatches disabling tests * toClips * label types test * more granular field selection when disabling label subfields * geolocation, heatmap, segmentation tests * complete disabling test * review comments * enable vector fields, disable top level id field, more grnular disabling of FrameSupportField and FrameNumberField * disable list of valid labels from visibility toggle * review comments * linting * editing pass * tweaks * cleanup * fixing capitalization * adding new vector integrations * bumping package versions * adding release notes * or count label tags (#3267) * has group slices only when group dataset (#3262) * Updating `Session.close()` (#3253) * kill server on session close * close desktop app * cleanup * lint * lint * is_open * rm remote warning * Embedded frame label fixes (#3256) * add frame cases to dynamic label tests * embedded frame label fixes * linting * adding a merge_sample() method * Minor typo fixes * adding test for one() method * updating release notes * tweak * documenting list bucket perms * Fix sidebar matching on label fields (#3270) * only matches * db_field bug and path fix * Suppress errors due to none fields (#3275) * don't throw error * add debug msg * import order * Fixing #3277 (#3279) * fixing filter_keypoints() bug * adding dynamic doc test * interactive typo fix for Dave * removing persistent dataset usage in unit tests * Sidebar filtering tests and fixes (#3280) * only matches * db_field bug and path fix * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * tweaks * exclude no only matches * add to release notes * whitespace * updating release notes * Minor fixes (#3283) * docs tweaks * documenting cache=True feature --------- Co-authored-by: manivoxel51 <mani@voxel51@gmail.com> Co-authored-by: Lanny W <lanzhenwang9@gmail.com> Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com> Co-authored-by: Brian Moore <brian@voxel51.com> Co-authored-by: imanjra <ibrahim@voxel51.com> Co-authored-by: topher <topher@voxel51.com> Co-authored-by: Jacob Marks <jamarks13@gmail.com> Co-authored-by: brimoor <brimoor@umich.edu> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com> Co-authored-by: Kishan Savant <ksavant577@gmail.com> Co-authored-by: Kacey <kacey@voxel51.com> Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com>
benjaminpkane
added a commit
that referenced
this pull request
Jul 12, 2023
* Release v0.21.2 (#3251) * update sidebar test, fix small regressions (#3250) * remove next index ref, fix string filter is matching default (#3249) * release notes * package bumps * disabled e2e * lint * fix mac arm64 * Teams v1.3.2 release note * rm e2e * add main * adding new vector integrations * bumping package versions * adding release notes * or count label tags (#3267) * has group slices only when group dataset (#3262) * Updating `Session.close()` (#3253) * kill server on session close * close desktop app * cleanup * lint * lint * is_open * rm remote warning * Embedded frame label fixes (#3256) * add frame cases to dynamic label tests * embedded frame label fixes * linting * adding a merge_sample() method * Minor typo fixes * adding test for one() method * updating release notes * tweak * documenting list bucket perms * Fix sidebar matching on label fields (#3270) * only matches * db_field bug and path fix * Suppress errors due to none fields (#3275) * don't throw error * add debug msg * import order * Fixing #3277 (#3279) * fixing filter_keypoints() bug * adding dynamic doc test * interactive typo fix for Dave * removing persistent dataset usage in unit tests * Sidebar filtering tests and fixes (#3280) * only matches * db_field bug and path fix * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * tweaks * exclude no only matches * add to release notes * whitespace * updating release notes * Minor fixes (#3283) * docs tweaks * documenting cache=True feature * Release/v0.21.3 (#3282) * Refactor schemaControls, use selectField() when searching, cleaner schema documentation selection mode is default now for filed visibility * update count dependency to refelct when applying filter rules * add documentation links * better disable field handling - (un)select is broken - fixing next * improve select all control * uncheck subpaths even if they are disabled * show embedded document in selection mode * field doc type using tertiary text color * minor tweaks in color modal title style * review comments and fix include nested fields selection view * review comments, refactor selection row, and count fix * add first vitest for visibility, upgrade vitest packages * add basic test and refactor more * keep one embed doc field * no coverage when yarn test * add support for multi-select with string type * adds a Docker Hub Pulls badge * Typo * tweaking * lint * Add files via upload * Update brain.rst * Update index.rst * Update index.rst * Update index.rst * Update index.rst * Release v0.21.2 (#3251) (#3255) * update sidebar test, fix small regressions (#3250) * remove next index ref, fix string filter is matching default (#3249) * release notes * package bumps * disabled e2e * lint * fix mac arm64 * Teams v1.3.2 release note * rm e2e * add main * add icon * typo * first pass at milvus integration docs * adding milvus to user_guide/brain * adding to integrations index * adding milvus logo * square image, lower resolution * editing pass * consistency * bugfixes * disable field unit testing * group and video dataset unit tests disabled * toPatches disabling tests * toClips * label types test * more granular field selection when disabling label subfields * geolocation, heatmap, segmentation tests * complete disabling test * review comments * enable vector fields, disable top level id field, more grnular disabling of FrameSupportField and FrameNumberField * disable list of valid labels from visibility toggle * review comments * linting * editing pass * tweaks * cleanup * fixing capitalization * adding new vector integrations * bumping package versions * adding release notes * or count label tags (#3267) * has group slices only when group dataset (#3262) * Updating `Session.close()` (#3253) * kill server on session close * close desktop app * cleanup * lint * lint * is_open * rm remote warning * Embedded frame label fixes (#3256) * add frame cases to dynamic label tests * embedded frame label fixes * linting * adding a merge_sample() method * Minor typo fixes * adding test for one() method * updating release notes * tweak * documenting list bucket perms * Fix sidebar matching on label fields (#3270) * only matches * db_field bug and path fix * Suppress errors due to none fields (#3275) * don't throw error * add debug msg * import order * Fixing #3277 (#3279) * fixing filter_keypoints() bug * adding dynamic doc test * interactive typo fix for Dave * removing persistent dataset usage in unit tests * Sidebar filtering tests and fixes (#3280) * only matches * db_field bug and path fix * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * base image sample tests * cleanup * exclude bug * rm onlyMatch * frame and dynamic tests * adding coverage * keypoints fixes * cleanup * tweaks * exclude no only matches * add to release notes * whitespace * updating release notes * Minor fixes (#3283) * docs tweaks * documenting cache=True feature --------- Co-authored-by: manivoxel51 <mani@voxel51@gmail.com> Co-authored-by: Lanny W <lanzhenwang9@gmail.com> Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com> Co-authored-by: Brian Moore <brian@voxel51.com> Co-authored-by: imanjra <ibrahim@voxel51.com> Co-authored-by: topher <topher@voxel51.com> Co-authored-by: Jacob Marks <jamarks13@gmail.com> Co-authored-by: brimoor <brimoor@umich.edu> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com> Co-authored-by: Kishan Savant <ksavant577@gmail.com> Co-authored-by: Kacey <kacey@voxel51.com> Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com> * Updating logo wall links (#3288) * updating logo wall links * better links --------- Co-authored-by: brimoor <brimoor@umich.edu> Co-authored-by: Kishan Savant <ksavant577@gmail.com> Co-authored-by: Brian Moore <brian@voxel51.com> Co-authored-by: Kacey <kacey@voxel51.com> Co-authored-by: topher <topher@voxel51.com> Co-authored-by: Kishan Savant <66986430+NeoKish@users.noreply.github.com> Co-authored-by: manivoxel51 <mani@voxel51@gmail.com> Co-authored-by: Lanny W <lanzhenwang9@gmail.com> Co-authored-by: manivoxel51 <109545780+manivoxel51@users.noreply.github.com> Co-authored-by: imanjra <ibrahim@voxel51.com> Co-authored-by: Jacob Marks <jamarks13@gmail.com> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds general integration coverage for labels, primitives, and field filtering in embedded contexts when creating the extended view via
Ensures
idto_idtranslation_label_tagcounts for pagination data