fix modal navigation bug

[sashankaryal]

.

Summary by CodeRabbit

• New Features

  • Enhanced navigation capabilities within the modal for improved user interaction.

• Bug Fixes

  • Adjusted visual placement of the navigation arrow for better user experience.

• Refactor

  • Streamlined the ModalSample component by removing unused imports and simplifying layout.

[coderabbitai]

Walkthrough

The changes consist of updates to the Modal component, including the addition of navigation capabilities through the onNavigate function. The ModalNavigation component's visual placement has been adjusted, and several unused imports and components have been removed from the ModalSamplePlugin, streamlining its functionality. Overall, the modifications enhance the user interaction and simplify the modal's structure.

Changes

File	Change Summary
app/packages/core/src/components/Modal/Modal.tsx	Added onNavigate from useLookerHelpers to enhance navigation capabilities within the Modal component.
app/packages/core/src/components/Modal/ModalNavigation.tsx	Changed the bottom CSS property of the Arrow styled component from 50% to 33vh, altering its visual placement.
app/packages/core/src/components/Modal/ModalSamplePlugin.tsx	Removed unused imports and components, including useLookerHelpers and ModalNavigation, simplifying the modal's layout.

Possibly related PRs

• fix tagger e2e tests #4783: Enhancements to the Modal component, potentially related to modifications in the ModalPom class, focusing on functionality and interaction within modals.

Poem

🐇 In the modal's dance, we twirl and sway,
With navigation bright, we find our way.
Arrows now higher, a new view to see,
Simplified paths, as smooth as can be.
Hooray for the changes, let joy take flight,
A rabbit's delight in the soft moonlight! 🌙

Warning

Review ran into problems

Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

app/packages/core/src/components/Modal/ModalSamplePlugin.tsx (1)

Line range hint 23-88: Consider extracting the tooltip functionality into a separate component.

The ModalSample component currently handles the tooltip functionality, which is not directly related to the modal's core purpose. Consider extracting the tooltip-related logic, including the tooltipEventHandler, useEffect hooks, and related Recoil state management, into a separate component. This will help further decouple the modal from the tooltip functionality and improve the component's adherence to the single responsibility principle.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 71e926a and 1901552.

Files selected for processing (3)

• app/packages/core/src/components/Modal/Modal.tsx (2 hunks)
• app/packages/core/src/components/Modal/ModalNavigation.tsx (1 hunks)
• app/packages/core/src/components/Modal/ModalSamplePlugin.tsx (1 hunks)

Additional context used

Path-based instructions (3)

app/packages/core/src/components/Modal/ModalSamplePlugin.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

app/packages/core/src/components/Modal/ModalNavigation.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

app/packages/core/src/components/Modal/Modal.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

Additional comments not posted (4)

app/packages/core/src/components/Modal/ModalSamplePlugin.tsx (1)

Line range hint 1-6: Approve the removal of unused imports and components.

The removal of unused imports and components related to ModalNavigation helps simplify the modal's structure and focus on its core purpose of rendering the appropriate child component based on the state.

Also applies to: 8-11

app/packages/core/src/components/Modal/ModalNavigation.tsx (1)

29-29: Approve the change in the arrow's positioning, but consider responsiveness.

The change in the bottom property of the Arrow component from 50% to 33vh will position the arrow consistently at one-third of the viewport height from the bottom, making it more easily accessible to users.

However, please consider testing the responsiveness and visual consistency of this change across various screen sizes and devices to ensure that the arrow's position remains appropriate relative to the modal's content.

app/packages/core/src/components/Modal/Modal.tsx (2)

12-12: LGTM!

The import statement for ModalNavigation is valid and follows the correct syntax.

---

167-168: LGTM!

The usage of the useLookerHelpers hook to access the onNavigate function follows the React hooks pattern and aligns with best practices.