increase zIndex of modal sidebar to fix resize bug #4860
Conversation
WalkthroughThe changes involve the addition of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/packages/core/src/components/Sidebar/Sidebar.tsx (1)
710-713: LGTM: Effective use of MUI theme for z-indexThe addition of the
styleprop to theResizablecomponent effectively addresses the resize bug mentioned in the PR objectives. The conditional setting ofzIndexfor modal mode is a good approach.Consider extracting the style object to a separate constant for improved readability:
const resizableStyle = { borderTopRightRadius: 8, ...(modal && { zIndex: muiTheme.zIndex.tooltip + 1 }), };Then use it like this:
<Resizable // ... other props style={resizableStyle} >This change would make the component props more concise and easier to read.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- app/packages/core/src/components/Sidebar/Sidebar.tsx (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/packages/core/src/components/Sidebar/Sidebar.tsx (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
🔇 Additional comments (2)
app/packages/core/src/components/Sidebar/Sidebar.tsx (2)
14-14: LGTM: Good use of import aliasingThe addition of the
useThemeimport from Material-UI and aliasing it asuseMUIThemeis a good practice. It avoids naming conflicts with the existinguseThemeimport and clearly indicates the source of the theme hook.
697-697: LGTM: Proper use of MUI theme hookThe addition of the
muiThemeconstant using theuseMUIThemehook is correct and follows React best practices. The naming is clear and consistent with the import alias.
What changes are proposed in this pull request?
increase zIndex of modal sidebar to fix resize bug
How is this patch tested? If it is not, please explain why.
By resizing the sidebar in modal
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changesSummary by CodeRabbit
New Features
Resizablecomponent in theInteractiveSidebar, enhancing its visual integration with Material-UI.Bug Fixes
zIndexhandling for theResizablecomponent when a modal is active, ensuring proper layering in the UI.