-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arch Linux support #191
Conversation
Can one of the admins verify this patch? |
e9a7ebe
to
5d426ad
Compare
My goal for this was to replace the EC2 nodesets, but we have since removed those. I don't have Arch, but this may be interesting for those who do. I don't have time to pick this up, but I can probably give hints to those who are interested. It should also list the docker nodeset and how to build it up. |
b8e5461
to
8a7e49e
Compare
new commit message: For the Vagrant backend, this creates the following Vagrantfile:
This PR also creates the correct Dockerfile, but I wasn't able to catch The correct usage is:
while this looks a bit odd, it matches the current design with other This in general works, but requires some updates to beaker-puppet to |
1fe93c6
to
d4597bf
Compare
There are a few related PRs that I want to document here:
|
d4597bf
to
dd3bbac
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
- Coverage 0.51% 0.51% -0.01%
=========================================
Files 14 14
Lines 2519 2531 +12
=========================================
Hits 13 13
- Misses 2506 2518 +12
Continue to review full report at Codecov.
|
dd3bbac
to
8d4e41a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, @ekohl I agree with your suggestion to alias archlinux-64
to archlinuxrolling-64
if you still want to add that.
8d4e41a
to
6909165
Compare
For the Vagrant backend, this creates the following Vagrantfile: ``` Vagrant.configure("2") do |c| c.ssh.insert_key = false c.vm.define 'archlinuxrolling-64-1' do |v| v.vm.hostname = 'archlinuxrolling-64-1' v.vm.box = 'archlinux/archlinux' v.vm.box_check_update = 'true' v.vm.synced_folder '.', '/vagrant', disabled: true v.vm.network :private_network, ip: "10.255.70.163", :netmask => "255.255.0.0", :mac => "0800278B1C64" v.vm.provider :virtualbox do |vb| vb.customize ['modifyvm', :id, '--memory', '1024', '--cpus', '1', '--audio', 'none'] end end end ``` This PR also creates the correct Dockerfile, but I wasn't able to catch the terminal output and the file isn't written to disk. The correct usage is: ``` BEAKER_setfile=archlinuxrolling-64{hypervisor=docker} BEAKER_setfile=archlinuxrolling-64{hypervisor=vagrant} ``` while this looks a bit odd, it matches the current design with other operating systems where the version number isn't separated from the OS name. This in general works, but requires some updates to beaker-puppet to install the correct puppet package.
6909165
to
efaef53
Compare
I can't approve my own PR, but 👍 |
This is incomplete since it's lacking tests, but I'm also unsure how if https://github.com/voxpupuli/modulesync_config/blob/4d4be4b600632c2fda96dde7f9ee53b4d248e078/moduleroot/spec/acceptance/nodesets/archlinux-2-x64.yml.erb#L12-L13 needs to be here as well.