Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arch Linux support #191

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 31, 2020

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@ekohl ekohl force-pushed the add-archlinux branch 2 times, most recently from e9a7ebe to 5d426ad Compare December 5, 2020 18:02
@ekohl
Copy link
Member Author

ekohl commented Dec 5, 2020

My goal for this was to replace the EC2 nodesets, but we have since removed those. I don't have Arch, but this may be interesting for those who do. I don't have time to pick this up, but I can probably give hints to those who are interested. It should also list the docker nodeset and how to build it up.

@bastelfreak
Copy link
Member

new commit message:

For the Vagrant backend, this creates the following Vagrantfile:

Vagrant.configure("2") do |c|
  c.ssh.insert_key = false
  c.vm.define 'archlinuxrolling-64-1' do |v|
    v.vm.hostname = 'archlinuxrolling-64-1'
    v.vm.box = 'archlinux/archlinux'
    v.vm.box_check_update = 'true'
    v.vm.synced_folder '.', '/vagrant', disabled: true
    v.vm.network :private_network, ip: "10.255.70.163", :netmask => "255.255.0.0", :mac => "0800278B1C64"
    v.vm.provider :virtualbox do |vb|
      vb.customize ['modifyvm', :id, '--memory', '1024', '--cpus', '1', '--audio', 'none']
    end
  end
end

This PR also creates the correct Dockerfile, but I wasn't able to catch
the terminal output and the file isn't written to disk.

The correct usage is:

BEAKER_setfile=archlinuxrolling-64{hypervisor=docker}
BEAKER_setfile=archlinuxrolling-64{hypervisor=vagrant}

while this looks a bit odd, it matches the current design with other
operating systems where the version number isn't separated from the OS
name.

This in general works, but requires some updates to beaker-puppet to
install the correct puppet package.

@bastelfreak bastelfreak marked this pull request as ready for review December 18, 2020 15:21
lib/beaker-hostgenerator/data.rb Show resolved Hide resolved
lib/beaker-hostgenerator/data.rb Outdated Show resolved Hide resolved
@bastelfreak bastelfreak force-pushed the add-archlinux branch 3 times, most recently from 1fe93c6 to d4597bf Compare December 19, 2020 19:17
@bastelfreak
Copy link
Member

There are a few related PRs that I want to document here:

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #191 (efaef53) into master (2adeb81) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #191      +/-   ##
=========================================
- Coverage    0.51%   0.51%   -0.01%     
=========================================
  Files          14      14              
  Lines        2519    2531      +12     
=========================================
  Hits           13      13              
- Misses       2506    2518      +12     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adeb81...efaef53. Read the comment docs.

Copy link
Member

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @ekohl I agree with your suggestion to alias archlinux-64 to archlinuxrolling-64 if you still want to add that.

For the Vagrant backend, this creates the following Vagrantfile:

```
Vagrant.configure("2") do |c|
  c.ssh.insert_key = false
  c.vm.define 'archlinuxrolling-64-1' do |v|
    v.vm.hostname = 'archlinuxrolling-64-1'
    v.vm.box = 'archlinux/archlinux'
    v.vm.box_check_update = 'true'
    v.vm.synced_folder '.', '/vagrant', disabled: true
    v.vm.network :private_network, ip: "10.255.70.163", :netmask => "255.255.0.0", :mac => "0800278B1C64"
    v.vm.provider :virtualbox do |vb|
      vb.customize ['modifyvm', :id, '--memory', '1024', '--cpus', '1', '--audio', 'none']
    end
  end
end
```

This PR also creates the correct Dockerfile, but I wasn't able to catch
the terminal output and the file isn't written to disk.

The correct usage is:

```
BEAKER_setfile=archlinuxrolling-64{hypervisor=docker}
BEAKER_setfile=archlinuxrolling-64{hypervisor=vagrant}
```

while this looks a bit odd, it matches the current design with other
operating systems where the version number isn't separated from the OS
name.

This in general works, but requires some updates to beaker-puppet to
install the correct puppet package.
@ekohl
Copy link
Member Author

ekohl commented Dec 9, 2021

I can't approve my own PR, but 👍

@GabrielNagy GabrielNagy merged commit c2902ca into voxpupuli:master Dec 9, 2021
@ekohl ekohl deleted the add-archlinux branch December 9, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants