Add Arch Linux support

[bastelfreak]

No description provided.

[ekohl]

This is blocked on getting beaker, beaker-puppet and beaker-hostgenerator releases out. voxpupuli/beaker-hostgenerator#191 (comment) has a good overview of what's needed. After that, 👍

[ekohl]

I'd like to avoid the duplication between here and the other 2 places. I'm not sure what the best place to capture it, but it feels like this should be captured in the metadata somehow.

[bastelfreak]

The code is now working . What do you think is the best to do deduplication? we could hack lib/puppet_metadata.rb and set the release to rolling for Arch Linux and Gentoo. But that could confuse people if they assume the metadata object is 1:1 what's in the metadata.json

[bastelfreak]

I'm testing this:

• Test Arch Linux acceptance testing puppet-nginx#1492
• Implement Arch Linux acceptance testing puppet-borg#90

[bastelfreak]

@ekohl can you take a look here again as well?

[ekohl]

Could you perhaps add some tests. I'd have expected it to fail here:

puppet_metadata/spec/metadata_spec.rb

Line 184 in 3977d94

describe 'beaker_setfiles' do

Looks like that ensures certain values are yielded, but not that nothing else is yielded.

[ekohl]

While it doesn't make a huge difference, it's better to do puppet_major_versions.map{|h| h[:value]}.sort.reverse.first outside of the loop. puppet_major_versions doesn't change within it and that makes it a bit more efficient. It can also be more readable if you assign it a variable because right now it's quite a long line.

Also, I think braces around os == 'Archlinux' && ... is clearer.

However, that does make me wonder if we should change the implementation to roughly thing:

metadata.operatingsystems.each_with_object([]) do |(os, releases), matrix_include|
  case os
  when 'Archlinux', 'Gentoo'
    setfile = PuppetMetadata::Beaker.os_release_to_setfile(os, 'rolling', use_fqdn: use_fqdn, pidfile_workaround: pidfile_workaround)
    if setfile
      puppet_version = puppet_major_versions.max_by { |version| version[:value] }[:value]
      matrix_include << construct_matrix_include(setfile, puppet_version)
    end
  else
    releases.each do |release|
      # Pretty much the current code but use construct_matrix_include
    end
  end
end

[bastelfreak]

I will have a look at your suggestion later again. for now I created two methods in the metadata class to provide the lowest/highest puppet versions. They are quite short but could be useful for others as well. I just tested it in https://github.com/voxpupuli/puppet-borg/pull/90/checks and it's working as expected.

[bastelfreak]

I'm a bit confused by construct_matrix_include(). That method doesn't yet exist?

[bastelfreak]

I implemented the method. The generated matrix works but the Arch Linux name is now a bit odd:

[bastelfreak]

mhm

irb(main):011:0> m.construct_matrix_include(setfile, puppet_version)
=>
{:setfile=>
  {:name=>"Archlinux rolling", :value=>"archlinuxrolling-64{hostname=archlinuxrolling-64.example.com}"},
 :puppet=>7}
irb(main):012:0>

[ekohl]

Again, here you can make a case statement and use yield just once. It may be easier to follow.