-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to automatically merge downstream PRs created by modulesync #149
Conversation
…lexity. Introduce the --pr-auto-merge option and add relevant docs.
I'm not sure I follow exactly what this has for a check. Do I understand it correctly that there's no check if the CI passed before merging? In that case, what is the point of a PR rather than a straight commit? You can even auto close it by fast forward merging it in master and pushing master. |
@joestump could you have a look at my comment? |
@ekohl I can add checks for CI via the statuses API. We have branch protections on |
I feel this is a valuable change that makes sense. It's optional to activate, so we don't break existing functionality. 👍 @joestump, would it be hard to add a few tests for your implementation? Tests would be great! I would merge the changes afterwards unless someone wants to veto against it. |
@bittner I'm not super great with Ruby testing. If you could point me at a PR I can crib from, I'll take a look at mocking something up. |
Hi. Thanks for this awesome PR! |
@bittner tests added. @bastelfreak would it be possible to follow up with that functionality in a later PR? How should that function? Should it simply skip? Poll while waiting on status? Other? |
I feel this feature doesn't fit within the tool and that makes me slightly against it. I'd prefer a tool that you can feed PRs, monitor them and merge when green. To me that's more the unix philosophy. Note Gitlab has this built in but GH needs some special attention. |
Going to close this out. Relevant tests have been copied over to #171. |
What does this PR do?
manage_pr
function. Rubocop was (rightfully) complaining about the complexity of this block and brings the PR code a bit more in line with the existingmanage_${thing}
pattern.--pr-auto-merge
to automatically merge downstream PRs created by Modulesync.spec/
from Rubocop checks.$stdout
and$stderr
, which worked best with RSpec'soutput()
checks.Why is this change being made?
My team and I are so lazy we can't be bothered to manually merge all of the PRs our robots make. This lets our robots do it for us. 🤖😂
How was this tested? How can the reviewer verify your testing?
We're still testing this. Please consider this a work in progress until I've confirmed later.
What gif best describes this PR or how it makes you feel?