Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip issuing a PR if one already exists for -b option #171

Merged
merged 7 commits into from
Mar 11, 2020

Conversation

joestump
Copy link
Contributor

@joestump joestump commented Oct 22, 2019

  • This checks for an existing PR for head into base. If a PR exists, we skip issuing the PR. Cleans up the code to comply with Rubocop.
  • Adds full test coverage for the manage_pr method.
  • Adds a default task for rake.
  • Switches output over to $stdout and $stderr.

@bastelfreak
Copy link
Member

Hi @joestump, thanks for the PR. @ekohl can you please also review this?

@joestump
Copy link
Contributor Author

I'll add tests once we figure out what we want to do with #149. There are tests for the entire manage_pr method in that PR (even if we just merge those for now).

@joestump
Copy link
Contributor Author

@bastelfreak @ekohl this is ready for a final review.

@ekohl ekohl merged commit fe30d21 into voxpupuli:master Mar 11, 2020
@joestump joestump deleted the jstump-duplidate-pr branch March 11, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants