Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify namespace in module_options #181

Merged
merged 4 commits into from
Jul 20, 2020
+8 −2
Merged

Allow to specify namespace in module_options #181

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8dd89e
Allow to specify namespace in module_options
raphink Jul 3, 2020
d622212
Don't fail when module_options is not a hash
raphink Jul 16, 2020
3e83fcb
lint
raphink Jul 16, 2020
8fa64cd
Add doc on overriding namesespace per module
raphink Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,9 @@ msync update -m "Commit message"
Available parameters for modulesync.yml

* `git_base` : The default URL to git clone from (Default: 'git@github.com:')
* `namespace` : Namespace of the projects to manage (Default: 'puppetlabs')
* `namespace` : Namespace of the projects to manage (Default: 'puppetlabs').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking for this PR, but I think we should drop the default. Puppetlabs is no longer using modulesync so exactly 0 users benefit from this default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will provide a new PR for that

This value can be overridden in the module name (e.g. 'namespace/mod') or by
using the `namespace` key for the module in `managed_modules.yml`.
* `branch` : Branch to push to (Default: 'master')
* `remote_branch` : Remote branch to push to (Default: Same value as branch)
* `message` : Commit message to apply to updated modules.
Expand Down