Allow to specify namespace in module_options #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fail to understand why the cucumber tests don't pass... |
ekohl
reviewed
Jul 16, 2020
|
That's right. The first way is probablematic though, when the namespace contains slashes. |
|
That's now merged :) |
|
Yep, I'll have a look on Monday, I'm on weekend already! |
|
Enjoy! |
Merged
|
@ekohl good for you? |
ekohl
approved these changes
Jul 20, 2020
| @@ -276,7 +276,9 @@ msync update -m "Commit message" | |||
| Available parameters for modulesync.yml | |||
|
|
|||
| * `git_base` : The default URL to git clone from (Default: 'git@github.com:') | |||
| * `namespace` : Namespace of the projects to manage (Default: 'puppetlabs') | |||
| * `namespace` : Namespace of the projects to manage (Default: 'puppetlabs'). | |||
There was a problem hiding this comment.
Not blocking for this PR, but I think we should drop the default. Puppetlabs is no longer using modulesync so exactly 0 users benefit from this default.
There was a problem hiding this comment.
I will provide a new PR for that
|
Do we want to squash the commits? |
|
Yep, let's squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.