Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pr_target_branch option #182

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Add pr_target_branch option #182

merged 5 commits into from
Jul 17, 2020

Conversation

raphink
Copy link
Member

@raphink raphink commented Jul 3, 2020

No description provided.

@raphink
Copy link
Member Author

raphink commented Jul 3, 2020

I don't understand why this is failing... I'll see about it later.

@raphink
Copy link
Member Author

raphink commented Jul 16, 2020

There, it should be ready now @bastelfreak !

@bastelfreak bastelfreak merged commit 89d2eda into voxpupuli:master Jul 17, 2020

* Set the PR/MR title with `--pr-title` or in `modulesync.yml` with the
`pr_title` attribute.
* Assign labels to the PR/MR with `--pr-labels` or in `modulesync.yml` with
the `pr_labels` attribute. **NOTE:** `pr_labels` should be a list. When
using the `--pr-labels` CLI option, you should use a comma separated list.
* Set the target branch with `--pr_target_branch` or in `modulesync.yml` with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really --pr_target_branch or --pr-target-branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems equivalent, considering all other options are declared with an underscore as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants