Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tight coupling to gha-puppet in gha workflow templates #887

Closed
h-haaks opened this issue Apr 23, 2024 · 1 comment · Fixed by #893
Closed

Remove tight coupling to gha-puppet in gha workflow templates #887

h-haaks opened this issue Apr 23, 2024 · 1 comment · Fixed by #893
Assignees

Comments

@h-haaks
Copy link
Contributor

h-haaks commented Apr 23, 2024

When adding new inputs to files in https://github.com/voxpupuli/gha-puppet/tree/v2/.github/workflows we always have to make changes to https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/workflows/ci.yml.erb to reflect this.

By adding a 'with' key to .sync.yml and checking @configs['with'] in ci.yml.erb we could remove this tight copling.

Sample .sync.yml

.github/workflows/ci.yml:
  with:
    beaker_hosts: 'host1:shard.ma;host2:slave,router.a'
    beaker_facter: 'mongodb_repo_version:MongoDB:4.4,5.0,6.0,7.0'
@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 23, 2024

To not break existing modules we have to implement this in 3 stages:
1: support 'with'
2: use 'with' in alle modules that use inputs
3: cleanup ci.yml.erb

@h-haaks h-haaks changed the title Remove tight coupling to gha-puppet in ci.yml.erb Remove tight coupling to gha-puppet in gha workflow files Apr 23, 2024
@h-haaks h-haaks self-assigned this Apr 23, 2024
@h-haaks h-haaks changed the title Remove tight coupling to gha-puppet in gha workflow files Remove tight coupling to gha-puppet in gha workflow templates May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant