Support arbitrary inputs to reusable workflow files #888
Conversation
| <%- @configs['with'].each do |k,v| -%> | ||
| <%= k %>: <%= v %> | ||
| <%- end -%> | ||
| <%- end -%> |
There was a problem hiding this comment.
I have tested this locally with
bundle exec msync update -f puppet-example --offline --noop where I made two local commits to the master branch of puppet-example.
1: added this to .sync.yml
.github/workflows/ci.yml:
rubocop: false
2: updated .sync.yml
.github/workflows/ci.yml:
with:
rubocop: false
Seems to work as expected.
There was a problem hiding this comment.
I don't think it's possible to test this change any more on real modules as the changes to .sync.yml has to be merged to main/master for msync to pick it up.
If I added with key and merge it, msync will fail on that module until the PR is merged.
There was a problem hiding this comment.
remove the --noop --offline from the msync call and provide a PR for puppet-example? That's how we usually do it.
There was a problem hiding this comment.
hmm, as expected it doesn't change anything in the local modulesync branch so it's not pushed ...
The puppet-example doesn't even have .github/workflows/ci.yml in it's sync file.
Do you want me to change puppet-example so that I can generate a diff?
There was a problem hiding this comment.
We often (ab)use puppet-example as our testing ground. Feel free to use that. Though with --offline (then --noop is redundant) it should take .sync.yml into account
There was a problem hiding this comment.
Ah, I didn't commit my changes to .sync.yml in the local modulsync branch before rerun of msync ...
There was a problem hiding this comment.
With --offline it shouldn't care about git and work purely local
There was a problem hiding this comment.
h-haaks
force-pushed
the
support-arbitrary-inputs-to-reusable-workflow-files
branch
from
a9de596
to
f6e8bc4
Compare
|
Rebased to sign my commit |
|
@bastelfreak @ekohl anything else needed or is this ready to merge now? |
Add possibility to use
withas a key to.github/workflows/ci.ymland.github/workflows/release.ymlin.sync.ymli.e:
or