add support for arbitrary with values for beaker.yml workflow
#858
Conversation
Example `.sync.yml` snippet:
.github/workflows/ci.yml:
with:
hosts: master,replica,client
jhoblitt
force-pushed
the
feature/beaker-multihost
branch
from
75a9497
to
97ac939
Compare
| @@ -22,6 +22,9 @@ jobs: | |||
| <%- if @configs['acceptance_tests'] && Dir[File.join(@metadata[:workdir], 'spec', 'acceptance', '**', '*_spec.rb')].any? -%> | |||
| uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v2 | |||
| with: | |||
| <%- if @configs['with'] -%> | |||
| <%= @configs['with'].to_yaml.split("\n")[1..-1].join.gsub(/^/, ' ' * 6) %> | |||
| <%- end -%> | |||
There was a problem hiding this comment.
I'm not very familiar with modulesync and this config, but if @configs['with'] is a hash why bother manipulating it as a multi line string and not just:
<%- if @configs['with'] -%>
<%- @configs['with'].each do |k,v| -%>
<%= k %>: <%= v %>
<%- end -%>
<%- end -%>
There was a problem hiding this comment.
Because yaml is sensitive to indention.
There was a problem hiding this comment.
Is there a plan to refactor all .sync.yml files so that we in the end could end up with this being something like:
<%- if @configs['acceptance_tests'] && Dir[File.join(@metadata[:workdir], 'spec', 'acceptance', '**', '*_spec.rb')].any? -%>
uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v2
<%- else -%>
uses: voxpupuli/gha-puppet/.github/workflows/basic.yml@v2
<%- end -%>
<%- if @configs['with'] -%>
with:
<%- @configs['with'].each do |k,v| -%>
<%= k %>: <%= v %>
<%- end -%>
<%- end -%>
There was a problem hiding this comment.
I think you volunteered...
There was a problem hiding this comment.
@h-haaks send us a PR :) and we could also switch to json if that's easier. I don't mind it.
There was a problem hiding this comment.
How do I actually test my changes?
There was a problem hiding this comment.
Created #887
I'll start working right away :)
There was a problem hiding this comment.
If you spin up a PR against this repo it will do a noop msync to all repos as a CI job and print you the diff. And please run msync against our puppet-example repo and provide a real PR.
|
I'm closing this. Please reopen it if needed :) |
Example
.sync.ymlsnippet:Related to: