Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #37 added directors hash for config via hiera #38

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

benibr
Copy link
Contributor

@benibr benibr commented May 13, 2019

This is the patch for #37
With this it is possible to specify directors for the webui in hiera.

@project0
Copy link
Collaborator

i know its possible with puppet > 4 and we should deprecate puppet 3/4, but create_resources should the way to go: https://puppet.com/docs/puppet/5.4/function.html#createresources

@ghoneycutt
Copy link
Member

@project0 suggest removing support for puppet3/4 and adding support for puppet5/6 along with data types to class params in a major version bump.

@benibr
Copy link
Contributor Author

benibr commented May 14, 2019

Thanks for clarification. I'm not ready to implement full puppet6 support yet, but I submitted a patch using create_resources which passes the checks and also works fine with hiera config.

@benibr
Copy link
Contributor Author

benibr commented May 17, 2019

any more suggestions or is this ready to be merged?

@project0
Copy link
Collaborator

lgtm, but some specs would be great if possible ;-)

@benibr
Copy link
Contributor Author

benibr commented Jun 7, 2019

Added puppet rspecs, had to get help with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants