Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to configure defined types via hiera #54

Merged
merged 9 commits into from
Jan 30, 2020

Conversation

benibr
Copy link
Contributor

@benibr benibr commented Dec 23, 2019

This is the corresponding PR for #41
Its based on the schema of #37 and allows to use all the defined types via a hiera hash which is then given to create_resources()

@benibr benibr force-pushed the feature/hiera_configurable branch 2 times, most recently from b35ab32 to 9551000 Compare December 23, 2019 16:44
manifests/director.pp Outdated Show resolved Hide resolved
@benibr benibr force-pushed the feature/hiera_configurable branch 4 times, most recently from 1553069 to 32297bf Compare December 24, 2019 10:29
@benibr
Copy link
Contributor Author

benibr commented Dec 24, 2019

The hashes for the defines work fine in my tests. Sadly the spec test report duplicate declarations of bareos::director and I can't figure out why. If I remove the pre_condition it compiles

let(:pre_condition) { 'class {"::bareos::director::director": password => "password" }' }

Someone knows what I am missing here?

@vox-pupuli-tasks
Copy link

Dear @benibr, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @benibr, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @benibr, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@benibr benibr force-pushed the feature/hiera_configurable branch 2 times, most recently from 206c2b4 to c4fcaab Compare January 15, 2020 15:46
@bastelfreak bastelfreak added enhancement New feature or request and removed needs-rebase labels Jan 30, 2020
@bastelfreak
Copy link
Member

thanks for the work!

@bastelfreak bastelfreak merged commit 9739286 into voxpupuli:master Jan 30, 2020
@bastelfreak bastelfreak changed the title added possibility to configure defined types via hiera Add possibility to configure defined types via hiera Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants