Remove undef values from the tags array #245
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes:
raise Exception("")
doesn't seem to work in ruby 1.9 or 2.x butraise Exception.new('')
doesThe second fix happens when you pass an undef inside the
$tags
variable. This causes consul_sorted_json to throw an exception. delete_undef_values doesn't seem to be able to remove the undef from the tags array inside the$basic_hash
hash.Explicitly running delete_undef_values on the tags fixes the issue.