Handle nested :undef in consul_sorted_json #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `consul_sorted_json` only handles top level `:undef` values,
leaving nested `:undef` values to slip through and eventually raise an
exception. Instead of trying to handle all `:undef`s upfront in the
function, handle them in the recursion and treat them as what they
actually are, `null`s.
I've also been encountering the `Exception("")` vs `Exception.new("")`
problem detailed in #245, as `Exception("")` is not valid syntax in
newer versions of Ruby. That fix is included here as well
mcasper
changed the title
|
Nice. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
consul_sorted_jsononly handles top level:undefvalues,leaving nested
:undefvalues to slip through and eventually raise anexception. Instead of trying to handle all
:undefs upfront in thefunction, handle them in the recursion and treat them as what they
actually are,
nulls.I've also been encountering the
Exception("")vsException.new("")problem detailed in #245, as
Exception("")is not valid syntax innewer versions of Ruby. That fix is included here as well