Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meta information on service #441

Closed
wants to merge 2 commits into from
Closed

Support meta information on service #441

wants to merge 2 commits into from

Conversation

KZachariassen
Copy link
Contributor

No description provided.

@solarkennedy
Copy link
Contributor

Can you pull/rebase against master please?

@@ -43,6 +43,7 @@
$service_name = $title,
$tags = [],
$token = undef,
$meta = {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a datatype to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get you? Its a {} that per definition is a Hash? Just like the $tags are a array?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default datatype is Hash in this case, but users could provide every other datatype as well. You can prefix the parameter with an explicit datatype, to enforce it. That would be:

Hash $meta = {},

@bastelfreak bastelfreak added enhancement New feature or request needs-tests labels Oct 2, 2018
@KZachariassen
Copy link
Contributor Author

I think this is a duplicate of #436 ?
Should we close this on and work on 436?

@jardleex
Copy link
Contributor

jardleex commented Feb 4, 2019

I think this can get closed due to #466

@stale
Copy link

stale bot commented Jan 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 24, 2021
@stale stale bot closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants