-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support meta information on service #441
Conversation
Can you pull/rebase against master please? |
@@ -43,6 +43,7 @@ | |||
$service_name = $title, | |||
$tags = [], | |||
$token = undef, | |||
$meta = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a datatype to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get you? Its a {}
that per definition is a Hash? Just like the $tags are a array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default datatype is Hash
in this case, but users could provide every other datatype as well. You can prefix the parameter with an explicit datatype, to enforce it. That would be:
Hash $meta = {},
I think this is a duplicate of #436 ? |
I think this can get closed due to #466 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
No description provided.