add optional service meta hash #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
bastelfreak
reviewed
Jan 28, 2019
manifests/service.pp
Outdated
| Hash $service_config_hash = {}, | ||
| $tags = [], | ||
| $token = undef, | ||
| Hash[String, String] $meta = {}, |
There was a problem hiding this comment.
Can you please enforce the minimal string lengt:
Suggested change
| Hash[String, String] $meta = {}, | |
| Hash[String[1], String[1]] $meta = {}, |
Please also align all the = chars in the parameter section.
bastelfreak
reviewed
Jan 28, 2019
| @@ -36,6 +36,9 @@ | |||
| # [*token*] | |||
| # ACL token for interacting with the catalog (must be 'management' type) | |||
| # | |||
| # [*meta*] | |||
There was a problem hiding this comment.
can you also mention this parameter in the README.md?
bastelfreak
added
enhancement
|
we need to wait until puppetlabs/beaker-puppet#102 got merged and released. That will fix the beaker jobs. |
|
Length enforcement is in. |
|
thanks! |
This was referenced Feb 4, 2019
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
add optional service meta hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as requested in #436 and similar to #441 this is an up-to-date PR based on latest master of solarkennedy and the work of sc0rp10.
It adds meta hash the a service definition. The hash is optional.
Note: I've not clue about the spec files. Just took over the changes initially made. Will need external input if something is broken there.
Best regards
jardleex