remove failing tests on centos6 + puppet 6 #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@solarkennedy should we also remove centos6 from the metadata.json? Also there was a recent change to the github-changelog gem and it seems it broke our whole testmatrix :( |
Closed
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
remove failing tests on centos6 + puppet 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test coverage is pretty comprehensive, but this centos6 build has been failing for about 2 months.
Bisecting it, here is the last green build:
https://travis-ci.org/solarkennedy/puppet-consul/jobs/551129989
And then the next red one:
https://travis-ci.org/solarkennedy/puppet-consul/jobs/562904128
Both use consul 1.2.3.
The one that fails has puppet agent 6.7. The Green build has puppet agent 6.5.
Here is a diff
https://pastebin.com/ntQXi0d9
I bet there is something "real" here, but I don't feel like spending time debugging it. Till then I think the broken test isn't providing any value. RFC?