Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow to pass ticket_id to API Feature #512

Closed
benningm opened this issue Jan 16, 2019 · 0 comments · Fixed by #514
Closed

Feature Request: Allow to pass ticket_id to API Feature #512

benningm opened this issue Jan 16, 2019 · 0 comments · Fixed by #514
Milestone

Comments

@benningm
Copy link

Currently it is only possible to pass the ticket_salt to generate the ticket_id.
If you dont have access to the servers ticket_salt it would be good if you can directly
pass the ticket_id to obtain the certificate.

class { '::icinga2::feature::api':
  pki             => 'icinga2',
  ca_host         => 'icinga2-master.example.com',
  ticket_id     => '<insert-id-generated-on-master>',
  # ...
}

Expected Behavior

When a ticket_id is given then it should use the ticket_id instead of generating it
from the ticket_salt and fqdn.

Current Behavior

The ticket_id is generated with an function from the fqdn and the ticket_salt.

In case no ticket_salt has been passed it defaults to the string 'TicketSalt' which
is confusing. It may be better to fail if no TicketSalt is set in this case.

Possible Solution

Add parameter ticket_id to icinga2::feature::api and use it if set.

Context

When the Icinga-Master is not under your control you may only have access to ticket_id
and not to the ticket_salt.

Or in case the module is used in a masterless puppet setup and you dont want store your ticket_salt local.

Your Environment

Applies to any environment.

benningm added a commit to benningm/puppet-icinga2 that referenced this issue Jan 16, 2019
Currently it is only possible to pass the ticket_salt to generate
ticket_id.

This adds a new parameter 'ticket_id' to allow setting the ticket
directly if the TicketSalt is not available.

closes voxpupuli#512
@lbetz lbetz added this to the v1.4.0 milestone Jan 16, 2019
lbetz added a commit that referenced this issue Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants