Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include every IP address into a cert's SAN field #32

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Include every IP address into a cert's SAN field #32

merged 1 commit into from
Apr 9, 2023

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Apr 9, 2023

Just localhost and default routed IPs were added to a SAN before. That causes a problem on a server with multiple NICs when etcd or kube-apiserver should be accessed via non-default route.

Just localhost and default routed IPs were added to a SAN before. That
causes a problem on a server with multiple NICs when etcd or
kube-apiserver should be accessed via non-default route.
@jay7x jay7x merged commit be7e0e5 into voxpupuli:master Apr 9, 2023
@jay7x jay7x deleted the more_sans branch April 9, 2023 14:13
@ananace
Copy link
Member

ananace commented Apr 13, 2023

I'm going to have to revert this again, it's causing issues as it's changing the SAN list - and therefore also triggering a recreation of the serving certs - every time a container starts or stops on the Kubernetes master nodes.

Additionally, it's also including link-local bindings as well as IPVS entries from kube-proxy into the certificates, which causes the SAN list to grow in size far too quickly. A simple test cluster with no active load is already up to 50 SANs, while our production cluster would have SAN lists with almost a thousand entries for each master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants