Revert "Include every IP address into a cert's SAN field" #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #32
To copy what I said there;
It's causing issues as it's changing the SAN list - and therefore also triggering a recreation of the serving certs - every time a container starts or stops on the Kubernetes master nodes.
Additionally, it's also including link-local bindings as well as IPVS entries from kube-proxy into the certificates, which causes the SAN list to grow in size far too quickly. A simple test cluster with no active load is already up to 50 SANs, while our production cluster would have SAN lists with almost a thousand entries for each master.