Allow setting file group owner #231
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "puppet-letsencrypt", | |||
| "version": "5.0.1-rc0", | |||
| "version": "6.0.1-rc0", | |||
There was a problem hiding this comment.
I don't think this is a major version.
There was a problem hiding this comment.
yes. please don't update the version. we do this during the next release.
| @@ -23,6 +24,7 @@ | |||
| Integer $propagation_seconds = 10, | |||
| Stdlib::Absolutepath $config_dir = $letsencrypt::config_dir, | |||
| Boolean $manage_package = true, | |||
| String $ini_file_owner_group = $letsencrypt::root_file_owner_group, | |||
There was a problem hiding this comment.
| String $ini_file_owner_group = $letsencrypt::root_file_owner_group, | |
| String[1] $ini_file_owner_group = $letsencrypt::root_file_owner_group, |
| Letsencrypt::Cron::Hour $cron_hour = $letsencrypt::renew_cron_hour, | ||
| Letsencrypt::Cron::Minute $cron_minute = $letsencrypt::renew_cron_minute, | ||
| Letsencrypt::Cron::Monthday $cron_monthday = $letsencrypt::renew_cron_monthday, | ||
| String $hook_file_owner_group = $letsencrypt::root_file_owner_group, |
There was a problem hiding this comment.
| String $hook_file_owner_group = $letsencrypt::root_file_owner_group, | |
| String[1] $hook_file_owner_group = $letsencrypt::root_file_owner_group, |
| @@ -50,7 +50,8 @@ | |||
| { | |||
| "operatingsystem": "OpenBSD", | |||
| "operatingsystemrelease": [ | |||
| "6.2" | |||
| "6.6", | |||
There was a problem hiding this comment.
mhm, is this a backwards incompatible change if we drop 6.2?
There was a problem hiding this comment.
i reckon that the latest supported versions are the last two, so it's more like a cleanup
There was a problem hiding this comment.
Indeed. I think it also didn't really break compatibility with 6.2. That's just an EOL OS.
There was a problem hiding this comment.
my issue with this PR is that we're introducing 4(?) parameters for 1 setting that was previously barely variable, or parametrisable.
so how about we just call this root_group, and be done with it?
how big is the chances that people will want to change this from the root (wheel) group to something else?
|
Btw, an alternative is to use the gid ( |
|
Dear @arthurbarton, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Add new optional parameter to set the group ownership of shipped files
Some Operating Systems (a current OpenBSD release) don't have group 'root' - this PR allows setting the group to something else.
Default of group:root has not changed
This Pull Request (PR) fixes the following issues
N/A