use a configurable root_group for things owned by root #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bastelfreak
reviewed
Jul 13, 2024
| @@ -55,7 +56,7 @@ class { 'letsencrypt': | |||
| is_expected.to contain_file("#{pathprefix}/etc/letsencrypt/dns-rfc2136.ini"). | |||
| with_ensure('file'). | |||
| with_owner('root'). | |||
| with_group('root'). | |||
| with_group("#{rootgroup}"). | |||
There was a problem hiding this comment.
you can directly use the variable
Suggested change
| with_group("#{rootgroup}"). | |
| with_group(rootgroup). |
bastelfreak
reviewed
Jul 13, 2024
| # | ||
| class letsencrypt::scripts () { | ||
| class letsencrypt::scripts ( | ||
| String[1] $root_group = $letsencrypt::root_group, |
There was a problem hiding this comment.
we don't need so much indent:
Suggested change
| String[1] $root_group = $letsencrypt::root_group, | |
| String[1] $root_group = $letsencrypt::root_group, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Change existing
_groupparameter toroot_groupand use it everywheregroup => 'root'is stated.I did not make the change backward compatible, the old parameter is renamed.
This Pull Request (PR) fixes the following issues
I took feedback on #231 . Since there is no
rootgroup, this fixes the module on FreeBSD and probably OpenBSD.