-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FreeBSD packages to Python 3.11 #352
Conversation
Maybe the FreeBSD hiera data needs to be split into files per FreeBSD major version, since this module claims to support 12, 13, and 14. Also we should probably drop 12 now that it's EOL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I guess you would want to install the same version of certbot regardless of FreeBSD release, so this is probably good.
I was going to tidy that up in a subsequent PR. |
Does this break FreeBSD 12? In other words, is #354 a requirement? |
FreeBSD 12 has reached EOL last year, no new packages are build for it, so with will "break" these EOL systems. But I think this change can be merged before the backward-incompatible changes. When the default FreeBSD version of python is updated, all supported versions of FreeBSD get new packages targeting that new version, so the current code is currently broken on all supported FreeBSD versions and this would fix it. Maybe a more reliable solution would be to allow to set a custom prefix ( |
That still feels like this is a backwards incompatible change, but I'll trust you on FreeBSD specifics. |
This was changed in the ports tree on May 29, commit 62a23ef0936e21fef507653054d6732bb7ef085f
700f7f1
to
19fbd1e
Compare
19fbd1e
to
3c3a4f4
Compare
Pull Request (PR) description
Update FreeBSD packages to Python 3.11.
This has been the default since May 29th.
This Pull Request (PR) fixes the following issues
On FreeBSD 14, Python versions need to be manually specified, as
py39-
packages are no longer available.