Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeBSD packages to Python 3.11 #352

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

rtprio
Copy link
Contributor

@rtprio rtprio commented Jul 11, 2024

Pull Request (PR) description

Update FreeBSD packages to Python 3.11.

This has been the default since May 29th.

This Pull Request (PR) fixes the following issues

On FreeBSD 14, Python versions need to be manually specified, as py39- packages are no longer available.

@kenyon
Copy link
Member

kenyon commented Jul 11, 2024

Maybe the FreeBSD hiera data needs to be split into files per FreeBSD major version, since this module claims to support 12, 13, and 14. Also we should probably drop 12 now that it's EOL.

@kenyon kenyon requested a review from smortex July 11, 2024 21:25
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I guess you would want to install the same version of certbot regardless of FreeBSD release, so this is probably good.

@rtprio
Copy link
Contributor Author

rtprio commented Jul 11, 2024

Also we should probably drop 12 now that it's EOL.

I was going to tidy that up in a subsequent PR.

@ekohl
Copy link
Member

ekohl commented Aug 5, 2024

Does this break FreeBSD 12? In other words, is #354 a requirement?

@smortex
Copy link
Member

smortex commented Aug 5, 2024

Does this break FreeBSD 12? In other words, is #354 a requirement?

FreeBSD 12 has reached EOL last year, no new packages are build for it, so with will "break" these EOL systems. But I think this change can be merged before the backward-incompatible changes.

When the default FreeBSD version of python is updated, all supported versions of FreeBSD get new packages targeting that new version, so the current code is currently broken on all supported FreeBSD versions and this would fix it.

Maybe a more reliable solution would be to allow to set a custom prefix (py311) because people can choose to use another verison of Python when they build their own packgaes. This would make it possible for people to use the version that match their system, and would not beak when the default version of Python change or is customized. Maybe this could be provided by the python module (where we indicate which version of python we use), but it is not a dependency of this module for now.

@ekohl
Copy link
Member

ekohl commented Aug 5, 2024

That still feels like this is a backwards incompatible change, but I'll trust you on FreeBSD specifics.

This was changed in the ports tree on May 29, commit
62a23ef0936e21fef507653054d6732bb7ef085f
@bastelfreak bastelfreak force-pushed the freebsd-python311 branch 3 times, most recently from 700f7f1 to 19fbd1e Compare September 9, 2024 21:22
@bastelfreak bastelfreak merged commit 27913b7 into voxpupuli:master Sep 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants