Remove EoL FreeBSD 12 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Jul 12, 2024
TheMeier
approved these changes
Jul 12, 2024
ekohl
reviewed
Aug 5, 2024
| @@ -21,7 +21,7 @@ class { 'letsencrypt': | |||
| case osfull | |||
| when 'RedHat-7', 'CentOS-7' | |||
| 'python2-certbot-dns-rfc2136' | |||
| when 'FreeBSD-12', 'FreeBSD-13' | |||
| when 'FreeBSD-13', 'FreeBSD-14' | |||
There was a problem hiding this comment.
If we drop EL7 support (which we now can) then this can be rewritten to simply test for the OS family and implicitly we get this for free: #356
Alternatively, this could simply be written like OpenBSD and remove the version specific constraint.
Suggested change
| when 'FreeBSD-13', 'FreeBSD-14' | |
| when %r{FreeBSD} |
Having said that, why does it pass on FreeBSD 14 both before and after this change?
bastelfreak
force-pushed
the
freebsd12eol
branch
from
3ea040d
to
8aa2d00
Compare
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Remove FreeBSD 12 from metadata and test matrix.
Add FreeBSD 14 to test matrix.
This Pull Request (PR) fixes the following issues
n/a