Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow puppet-lint 3; rake 13; drop rubocop #20

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Allow puppet-lint 3; rake 13; drop rubocop #20

merged 1 commit into from
Feb 24, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak self-assigned this Feb 24, 2023
@bastelfreak bastelfreak added the enhancement New feature or request label Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (30b2be3) compared to base (28f233c).
Patch has no changes to coverable lines.

❗ Current head 30b2be3 differs from pull request most recent head e00bb62. Consider uploading reports for the commit e00bb62 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
=========================================
  Hits            10        10

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit 0e3da43 into master Feb 24, 2023
@bastelfreak bastelfreak deleted the deps branch February 24, 2023 10:34
alexjfisher
alexjfisher reviewed Feb 24, 2023
View reviewed changes
puppet-lint-topscope-variable-check.gemspec
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
spec.add_development_dependency 'rspec-its', '~> 1.0'
spec.add_development_dependency 'rubocop', '~> 0.58'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak How come?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we didn't actually run rubocop and the config is totally outdated. and the version 0.58 brings conflicts with newer ruby versions. We're currently discussing how to handle rubocop for puppet-lint + our plugins and want to unify that, after the next puppet-lint release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher left review comments

@sebastianrakel sebastianrakel sebastianrakel approved these changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @alexjfisher @sebastianrakel