Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow puppet-lint 3; rake 13; drop rubocop #20

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Allow puppet-lint 3; rake 13; drop rubocop #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .rubocop.yml
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions puppet-lint-topscope-variable-check.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ Gem::Specification.new do |spec|
A puppet-lint plugin to check that topscope variable names don't start with ::.
DESC

spec.add_dependency 'puppet-lint', '~> 2.0'
spec.add_development_dependency 'rake', '~> 12.0'
spec.add_dependency 'puppet-lint', '>= 2.0', '< 4'
spec.add_development_dependency 'rake', '>= 12.0', '< 14'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
spec.add_development_dependency 'rspec-its', '~> 1.0'
spec.add_development_dependency 'rubocop', '~> 0.58'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak How come?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we didn't actually run rubocop and the config is totally outdated. and the version 0.58 brings conflicts with newer ruby versions. We're currently discussing how to handle rubocop for puppet-lint + our plugins and want to unify that, after the next puppet-lint release.

spec.add_development_dependency 'simplecov'
end