Add AlmaLinux 8 and Centos/Rocky/OracleLinux/AlmaLinux 9 to supported OS #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
approved these changes
Mar 11, 2024
ekohl
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Looking at https://github.com/voxpupuli/puppet-openvmtools/blob/master/spec/classes/openvmtools_init_spec.rb I see this module doesn't use rspec-puppet-facts so it doesn't actually test it out with the facts from those operating systems. It also doesn't have acceptance tests so there's little guarantee this actually works based on CI. That doesn't have to block merging, but something to be aware of.
|
@ekohl We can implement acceptance test forcing facts vmware, but the service can't start because the unit require a flag that docker set differently |
Closed
TheMeier
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add AlmaLinux 8 and Centos/Rocky/OracleLinux/AlmaLinux 9 to supported OS
This Pull Request (PR) fixes the following issues
Fixes #56