Refactor unit test

[Valantin]

Pull Request (PR) description

Refactoring the unit test to iterate on the supported os

This Pull Request (PR) fixes the following issues

Fixes #79

[ekohl]

You usually end up with code like:

describe 'openvmtools' do
  on_supported_os.each do |os, os_facts|
    context "os #{os}" do
      let(:facts) { os_facts.merge(virtual: 'vmware') }
      let(:package_name) do
        case facts[:os]['family']
        when 'RedHat'
          'open-vm-tools'
        else
          'whatever'
        end

        it { is_expected.to contain_package(package_name) }
      end
    end
  end
end

Note the difference between os_facts and facts is that the latter one is the fully merge one where os_facts is provided by the top layer. You can only use it within it blocks.

[jay7x]

I see missing a end here.. but maybe my builtin ruby interpreter misinterprets something in the end of the day 🤔

[Valantin]

The end is after the last it {} statement

[ekohl]

@jay7x is correct that the let block needs to be closed

[ekohl]

Is it still WIP (as the title says) or ready to be merged?

[Valantin]

For now I think is ok