Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh mco if we install the r10k app #15

Merged
merged 2 commits into from
Oct 14, 2013
Merged

refresh mco if we install the r10k app #15

merged 2 commits into from
Oct 14, 2013

Conversation

nvalentine-puppetlabs
Copy link
Contributor

Move to collector so we are not parse order dependent / conflicting with the mco module for Service[pe-mcollective].

ensure => running,
}
Service <| title == $mc_service |> {
subscribe => File["${app_path}/${app_name}"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvalentine-puppetlabs So did you give +> a try and it did not work? I can't remember if plusignment works in collector overrides. If it does that would be the better solution as it would not wipe out any existing subscriptions. We probably also need a note in README that this change requires you to have defined the service as the collector will not declare it , its self. This is fine for PE clients but FOSS machines might not I suppose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a typo. I corrected it in the PR. Will test @ client site tomorrow but I'm pretty sure it should be okay.

acidprime added a commit that referenced this pull request Oct 14, 2013
@acidprime acidprime merged commit 10bcd80 into voxpupuli:master Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants