Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh mco if we install the r10k app #15

Merged
merged 2 commits into from
Oct 14, 2013
+2 −5
Merged

refresh mco if we install the r10k app #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28a72dd
refresh mco if we install the r10k app
nvalentine-puppetlabs Oct 8, 2013
492a57b
Doh! +> not =>
nvalentine-puppetlabs Oct 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions manifests/mcollective.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@
require => File["${agent_path}/${agent_ddl}"],
}

# Create a service resource for the notification
if ! defined(Service[$mc_service]) {
service { $mc_service :
ensure => running,
}
Service <| title == $mc_service |> {
subscribe => File["${app_path}/${app_name}"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvalentine-puppetlabs So did you give +> a try and it did not work? I can't remember if plusignment works in collector overrides. If it does that would be the better solution as it would not wipe out any existing subscriptions. We probably also need a note in README that this change requires you to have defined the service as the collector will not declare it , its self. This is fine for PE clients but FOSS machines might not I suppose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a typo. I corrected it in the PR. Will test @ client site tomorrow but I'm pretty sure it should be okay.

}
}