Webhook: ability to pass extra arguments to mco #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a temporary check that will check if @puppetversion is >= '4.2.0' OR == '4.10.0' and if either match, then ruby path is set to /opt/puppetlabs/puppet/bin/ruby. This is to get the script working properly again until a solution can be found to ruby semver not recognizing minor release versions greather than '9'
|
@nike38rus can you get us a clean rebase with only your commits in it? |
|
I drunk a lot of vodka yesterday and my bear Mishka deleted my forked repo from GitHub when I play on balalaika so I had to create another fork. Me and Mishka are very sorry about this. I'll open new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for finer mco control e.g. to pass
--no-progressargument to reduce size of access log