Webhook: ability to pass extra arguments to mco #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself looks good, just needs some documentation/examples and an rspec test update. |
|
@rnelson0 it seems I'm done |
rnelson0
requested changes
Apr 19, 2017
manifests/webhook/config.pp
Outdated
| @@ -44,6 +44,7 @@ | |||
| $configfile_symlink = '/etc/webhook.yaml', | |||
| $enable_mutex_lock = $r10k::params::webhook_enable_mutex_lock, | |||
| Array $ignore_environments = $r10k::params::webhook_ignore_environments, | |||
| $mco_arguments = $r10k::params::webhook_mco_arguments, | |||
There was a problem hiding this comment.
This should be a String, correct?
There was a problem hiding this comment.
Well, if user didn't specified this parameter then default undef will be used so I guess it should be Variant[String, Undef] ?
There was a problem hiding this comment.
I think Optional[String] is better.
|
@rnelson0 done! |
rnelson0
approved these changes
Apr 19, 2017
|
Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of a #362
This will be useful for finer mco control e.g. to pass
--no-progressargument to reduce size of access logAlso I made some changes in authentication events logging and fixed identations