Support binding to all interfaces #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexjfisher
force-pushed
the
bind
branch
2 times, most recently
from
fafe534 to
9cb74b0
Compare
runejuhl
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
LGTM. Only nitpick is alignment of parameters and unnecessary parens
`bind` now takes an array (of IP addresses). To bind to all interfaces, use `bind => []`. Due to the new parameter validation, if you were previously using a single string to specify multiple IP addresses, you will need to change this to an array. Fixes voxpupuli#257 Fixes voxpupuli#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindnow takes an array (of IP addresses).To bind to all interfaces, use
bind => [].Due to the new parameter validation, if you were previously using a
single string to specify multiple IP addresses, you will need to change
this to an array.
Fixes #257
Fixes #60