fix unknown variable: staged_package #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a proposed fix for #169. This reveals new errors that I don't quite understand yet. I'm not sure if we've multiple bugs in the code or if this patch is wrong. @TraGicCode and idea? |
|
Yea i believe that was what was proposed. It's more of a patch then a true fix of the actual problem. |
|
This seems fine to me. I think the these errors were hidden by this bug you just fixed. Can i merge this? |
TraGicCode
approved these changes
Mar 28, 2018
TraGicCode
previously requested changes
Mar 28, 2018
Closed
TraGicCode
dismissed
their stale review
I've started contributing to help fix the issue.
TraGicCode
force-pushed
the
filepath_error
branch
from
7251e2a to
5862fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.