Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fixes #180

Closed
wants to merge 2 commits into from
Closed

Windows fixes #180

wants to merge 2 commits into from

Conversation

michaelweiser
Copy link
Contributor

Hi,

when rebased against #179 these changes fix the remaining Windows problems:

  • the config file resources actually do not use the correct path on Windows and this problem is called out by the test suite
  • service and package names differ on Windows

@TraGicCode
Copy link
Contributor

Hey @michaelweiser ,

I went ahead and simply excluded windows from the splunk-server tests. Even fixing the unit tests would require more testing and this makes the most sense at the time. I also noticed the packages you had for windows were different then what i had installed on my windows box for splunk server. Anyways just giving you a heads up and will go ahead and close this. If you Feel like a challenge free to implement #151 and add these tests :)

@TraGicCode TraGicCode closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants