Allow additional option for $cache parameter #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd is a classBreaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 8 modules (near match):This module is declared in 8 of 576 indexed public
|
|
LGTM. Could you add a unit test for this please? |
Update the cache parameter on init class to match the allowed values for resolved.
|
Added testing around the cache variants. |
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
* Allow additional option for $cache parameter Update the cache parameter on init class to match the allowed values for resolved. * added tests for resolved cache variants
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
* Allow additional option for $cache parameter Update the cache parameter on init class to match the allowed values for resolved. * added tests for resolved cache variants
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Support paramatized yum::versionlock
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Correct acceptence tests for DNF (8) system Use the new versionlock specification from voxpupuli#169 on CentOS 8. Also test the new specification on 7 and 8 also. Finally test that if samba-devel is filtered at an impossible version it is no longer available. This for the yum case probably assumes that samba-devel is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cache parameter on init class to match the allowed values for
resolved.
This addresses the issue brought up here: #166
#140 initally added the ability to use the no-negative option for resolved, however it did not include the corresponding adjustment to allow controlling the value from the init class.