expose the daemon_reload parameter from systemd::drop_in to systemd::service_limits

[gfa]

I did need this to break a dependency cycle when calling systemd::service_limits and systemd::timer (with different resources) within the same class

[gfa]

There are 15 tests that fail always

rspec ./spec/defines/dropin_file_spec.rb[1:1:1:10:1] # systemd::dropin_file supported operating systems on redhat-8-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:2:10:1] # systemd::dropin_file supported operating systems on ubuntu-18.04-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:3:10:1] # systemd::dropin_file supported operating systems on oraclelinux-7-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:4:10:1] # systemd::dropin_file supported operating systems on ubuntu-16.04-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:5:10:1] # systemd::dropin_file supported operating systems on archlinux-5-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:6:10:1] # systemd::dropin_file supported operating systems on centos-8-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:7:10:1] # systemd::dropin_file supported operating systems on centos-7-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:8:10:1] # systemd::dropin_file supported operating systems on fedora-30-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:9:10:1] # systemd::dropin_file supported operating systems on redhat-7-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:10:10:1] # systemd::dropin_file supported operating systems on debian-9-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:11:10:1] # systemd::dropin_file supported operating systems on debian-10-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:12:10:1] # systemd::dropin_file supported operating systems on sles-15-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:13:10:1] # systemd::dropin_file supported operating systems on debian-8-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:14:10:1] # systemd::dropin_file supported operating systems on sles-12-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

rspec ./spec/defines/dropin_file_spec.rb[1:1:15:10:1] # systemd::dropin_file supported operating systems on virtuozzolinux-7-x86_64 with sensitve content is expected to contain File[/etc/systemd/system/sensitive.service.d/sensitive.conf] with ensure => "file" and content  supplied string

I get those errors even when running locally against master, and in other PRs I see the same errors #167 #169

[ekohl]

I'm not a maintainer, but thoughts on #171?

[gfa]

I'm not a maintainer, but thoughts on #171?

I just saw #171, looks pretty good and it will solve my problem :)
However I have machines running puppet agent < 5 so i cannot yet drop this

I'll check how fast can we upgrade puppet agents and luckily close this PR :)

[raphink]

I'm in favor of #171