Drop Puppet 4 and 5 support + daemon-reload code #171

ekohl · 2021-01-13T11:31:48Z

Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually when restarting a service. That means it's possible to drop this code. Since Puppet 4 & 5 are now EOL, this should be ok.

Additionally it contains some documentation fixes (#172).

Alternative to #148.

ekohl · 2021-01-13T11:36:35Z

manifests/service_limits.pp

@@ -75,7 +75,6 @@
      path        => $::path,
      refreshonly => true,
      subscribe   => File["${path}/${name}.d/90-limits.conf"],
-      require     => Class['systemd::systemctl::daemon_reload'],


I'm a bit unsure about this (which is also why this is a draft). This isn't a service type so it doesn't perform the reload if needed. Not sure how to deal with this.

@raphink any thoughts on this?

Looks likes it should stay then...

But if the class to require is gone, should there be a local daemon reload?

ekohl · 2021-01-14T18:03:40Z

Rebased since the included PR was merged so the diff is smaller. No actual change.

ekohl

I have since found out that there are edge cases where you do need daemon-reload. Not sure if we want account for that. I can see about writing up something in the README.

tuxmea · 2021-02-18T14:37:40Z

Alternative to #179

This picks version 6.1.0 as a new lower bound since that contains code to automatically run daemon-reload if needed. Versions 4 and 5 are EOL.

ekohl · 2021-02-18T14:46:32Z

Just a trivial rebase now to see if the tests are green, no actual code change.

Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually when restarting a service. That means it's possible to drop this code.

ekohl · 2021-02-18T16:40:32Z

I added a section to the README but then I realized I hadn't addressed the service limits case. Can anyone take a look if this is a good direction or would you prefer to solve it with code?

trevor-vaughan · 2021-02-18T16:51:02Z

@ekohl Since it only occurs during a removal, I'd much rather have it handled in code if possible. Without that, we'll all end up with a bunch of confused end users at some point.

When the upstream code is corrected, a new version can be released that removes the workaround.

ekohl · 2021-02-22T16:57:24Z

It happens in an odd edge case. The following code doesn't suffer from it:

systemd::unit_file { 'myservice.service':
  ensure => absent,
  active => true,
}

That's because the module considers that an invalid state.

This does:

systemd::unit_file { 'myservice.service':
  ensure => absent,
}

service { 'myservice':
  ensure  => running,
  require => Systemd::Unit_file['myservice.service'],
}

What happened in puppetlabs-postgresql was exactly that. It switched from a module provided unit file to a package provided unit file.

I'm pushing the update as a separate commit for easier review. Let me know what you think.

Prior to this commit, the follow code did not suffer from PUP-9473: systemd::unit_file { 'myservice.service': ensure => absent, active => true, } That's because the module considers that an invalid state and fails to compile. The follow code did trigger the bug: systemd::unit_file { 'myservice.service': ensure => absent, } service { 'myservice': ensure => running, require => Systemd::Unit_file['myservice.service'], } That's precisely what happens when a module switches from a module-provided unit file to a package-provided unit file.

trevor-vaughan

👁️ 👍

raphink

LGTM

Puppet 5 support was dropped in voxpupuli#171, so no need to test with it anymore.

This is not needed anymore since Puppet 6. voxpupuli/puppet-systemd#171

… testing (#183) * metadata: allow Puppet 7 * .travis.yml: remove Puppet 5, add Puppet 7 Puppet 5 support was dropped in #171, so no need to test with it anymore.

See also voxpupuli/puppet-systemd#171

…stemd module, because the class was deprecated by the change voxpupuli/puppet-systemd#171

This is apparently not needed anymore on Puppet 6. voxpupuli/puppet-systemd#171

* Drop Puppet 4 and 5 support This picks version 6.1.0 as a new lower bound since that contains code to automatically run daemon-reload if needed. Versions 4 and 5 are EOL. * Drop daemon-reload code Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually when restarting a service. That means it's possible to drop this code. * Implement a workaround for PUP-9473. Prior to this commit, the follow code did not suffer from PUP-9473: systemd::unit_file { 'myservice.service': ensure => absent, active => true, } That's because the module considers that an invalid state and fails to compile. The follow code did trigger the bug: systemd::unit_file { 'myservice.service': ensure => absent, } service { 'myservice': ensure => running, require => Systemd::Unit_file['myservice.service'], } That's precisely what happens when a module switches from a module-provided unit file to a package-provided unit file.

… testing (voxpupuli#183) * metadata: allow Puppet 7 * .travis.yml: remove Puppet 5, add Puppet 7 Puppet 5 support was dropped in voxpupuli#171, so no need to test with it anymore.

* Drop Puppet 4 and 5 support This picks version 6.1.0 as a new lower bound since that contains code to automatically run daemon-reload if needed. Versions 4 and 5 are EOL. * Drop daemon-reload code Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually when restarting a service. That means it's possible to drop this code. * Implement a workaround for PUP-9473. Prior to this commit, the follow code did not suffer from PUP-9473: systemd::unit_file { 'myservice.service': ensure => absent, active => true, } That's because the module considers that an invalid state and fails to compile. The follow code did trigger the bug: systemd::unit_file { 'myservice.service': ensure => absent, } service { 'myservice': ensure => running, require => Systemd::Unit_file['myservice.service'], } That's precisely what happens when a module switches from a module-provided unit file to a package-provided unit file.

… testing (voxpupuli#183) * metadata: allow Puppet 7 * .travis.yml: remove Puppet 5, add Puppet 7 Puppet 5 support was dropped in voxpupuli#171, so no need to test with it anymore.

`daemon_reload` no longer needed as of Puppet 6.1.0, and it was dropped in `puppet/camptocamp` 3.0[1] [1]: voxpupuli/puppet-systemd#171

This patch updates from camptocamp/systemd 2.x to puppet/systemd 3.x This bump is driven by simp/simp-core#829 `daemon_reload` no longer needed as of Puppet 6.1.0, and it was dropped in `puppet/camptocamp` 3.0[1] [1]: voxpupuli/puppet-systemd#171

Remove nested code blocks from string docs

…le 'systemd' (#13542) Do so, in particular, to support the migration from the deprecated module 'camptocamp/systemd' to the maintained module 'puppet/systemd'. References: • voxpupuli/puppet-systemd#171 • https://github.com/voxpupuli/puppet-systemd/blob/master/README.md#daemon-reloads

…le 'systemd', when relevant (#13542) Do so, in particular, to support the migration from the deprecated module 'camptocamp/systemd' to the maintained module 'puppet/systemd'. References: • voxpupuli/puppet-systemd#171 • https://github.com/voxpupuli/puppet-systemd/blob/master/README.md#daemon-reloads

ekohl mentioned this pull request Jan 13, 2021

Move lint control statements out of documentation #172

Merged

ekohl commented Jan 13, 2021

View reviewed changes

ekohl mentioned this pull request Jan 13, 2021

expose the daemon_reload parameter from systemd::drop_in to systemd::service_limits #168

Closed

ekohl force-pushed the drop-daemon-reload branch from b683806 to 954cd0a Compare January 14, 2021 18:03

ekohl mentioned this pull request Feb 18, 2021

Make daemon-reload usable multiple times #179

Closed

ekohl commented Feb 18, 2021

View reviewed changes

Drop Puppet 4 and 5 support

12f609c

This picks version 6.1.0 as a new lower bound since that contains code to automatically run daemon-reload if needed. Versions 4 and 5 are EOL.

ekohl force-pushed the drop-daemon-reload branch from 954cd0a to 7062aa9 Compare February 18, 2021 14:46

Drop daemon-reload code

a76a4b6

Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually when restarting a service. That means it's possible to drop this code.

ekohl force-pushed the drop-daemon-reload branch from 7062aa9 to a76a4b6 Compare February 18, 2021 16:34

ekohl marked this pull request as ready for review February 18, 2021 16:34

tuxmea mentioned this pull request Feb 19, 2021

Cyclic dependency error when using systemd::unit_file in multiple classes #178

Closed

trevor-vaughan reviewed Feb 22, 2021

View reviewed changes

raphink approved these changes Feb 23, 2021

View reviewed changes

raphink added the backwards-incompatible label Feb 23, 2021

bastelfreak approved these changes Feb 23, 2021

View reviewed changes

raphink merged commit 97dd16f into voxpupuli:master Feb 23, 2021

ekohl deleted the drop-daemon-reload branch March 2, 2021 00:04

wyardley mentioned this pull request Mar 4, 2021

Not compatible with latest puppet-systemd voxpupuli/puppet-rabbitmq#875

Closed

kenyon added a commit to kenyon/puppet-systemd that referenced this pull request Mar 7, 2021

.travis.yml: remove Puppet 5, add Puppet 7

5951c6d

Puppet 5 support was dropped in voxpupuli#171, so no need to test with it anymore.

jonasdemoor added a commit to jonasdemoor/puppet-snmp that referenced this pull request Mar 16, 2021

Drop systemd daemon-reload for snmp services

ee27e00

This is not needed anymore since Puppet 6. voxpupuli/puppet-systemd#171

jonasdemoor mentioned this pull request Mar 16, 2021

Drop systemd daemon-reload for snmp services vStone/puppet-snmp#1

Merged

martin-koerner mentioned this pull request Apr 19, 2021

allow latest dependencies voxpupuli/puppet-kafka#326

Merged

ekohl mentioned this pull request Apr 22, 2021

daemon reload problem with 3.0.0 #190

Closed

TwizzyDizzy added a commit to TwizzyDizzy/puppet-rabbitmq that referenced this pull request Apr 22, 2021

Not needed anymore since Puppet 6

165d0a1

See also voxpupuli/puppet-systemd#171

TwizzyDizzy mentioned this pull request Apr 22, 2021

Remove superfluous daemon-reload code and raise minimum required puppet version to 6.1.0 voxpupuli/puppet-rabbitmq#885

Closed

evgenkisel pushed a commit to evgenkisel/puppet-kafka that referenced this pull request May 18, 2021

Removing SystemD reloading step by a special class from camptocamp/sy…

403f0c6

…stemd module, because the class was deprecated by the change voxpupuli/puppet-systemd#171

evgenkisel mentioned this pull request May 18, 2021

Removing SystemD reloading step voxpupuli/puppet-kafka#327

Merged

simondeziel added a commit to simondeziel/puppet-wireguard that referenced this pull request Jun 3, 2021

Drop systemd daemon-reload

9929ab9

This is apparently not needed anymore on Puppet 6. voxpupuli/puppet-systemd#171

Heidistein mentioned this pull request Jun 9, 2021

systemd had dropped support for daemon reload. markt-de/puppet-solr#4

Closed

bastelfreak mentioned this pull request Aug 30, 2021

Support Windows grafana/puppet-promtail#33

Open

op-ct added a commit to op-ct/pupmod-simp-selinux that referenced this pull request Jun 6, 2022

Update camptocamp ref, remove daemon_reload

9cf63fa

`daemon_reload` no longer needed as of Puppet 6.1.0, and it was dropped in `puppet/camptocamp` 3.0[1] [1]: voxpupuli/puppet-systemd#171

op-ct pushed a commit to op-ct/puppet-systemd that referenced this pull request Jun 17, 2022

Merge pull request voxpupuli#171 from traylenator/fixrender

6b599b1

Remove nested code blocks from string docs

samy-mahmoudi mentioned this pull request Sep 2, 2022

DIO: Stop notifying class 'systemd::systemctl::daemon_reload' of module 'systemd', when relevant (#13542) xelerance/puppet-wireguard#2

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop Puppet 4 and 5 support + daemon-reload code #171

Drop Puppet 4 and 5 support + daemon-reload code #171

ekohl commented Jan 13, 2021 •

edited

Loading

ekohl Jan 13, 2021

ekohl Jan 14, 2021

raphink Jan 18, 2021

ekohl Jan 18, 2021

ekohl commented Jan 14, 2021

ekohl left a comment

tuxmea commented Feb 18, 2021

ekohl commented Feb 18, 2021

ekohl commented Feb 18, 2021

trevor-vaughan commented Feb 18, 2021

ekohl commented Feb 22, 2021

trevor-vaughan left a comment

raphink left a comment

Drop Puppet 4 and 5 support + daemon-reload code #171

Drop Puppet 4 and 5 support + daemon-reload code #171

Conversation

ekohl commented Jan 13, 2021 • edited Loading

ekohl Jan 13, 2021

Choose a reason for hiding this comment

ekohl Jan 14, 2021

Choose a reason for hiding this comment

raphink Jan 18, 2021

Choose a reason for hiding this comment

ekohl Jan 18, 2021

Choose a reason for hiding this comment

ekohl commented Jan 14, 2021

ekohl left a comment

Choose a reason for hiding this comment

tuxmea commented Feb 18, 2021

ekohl commented Feb 18, 2021

ekohl commented Feb 18, 2021

trevor-vaughan commented Feb 18, 2021

ekohl commented Feb 22, 2021

trevor-vaughan left a comment

Choose a reason for hiding this comment

raphink left a comment

Choose a reason for hiding this comment

ekohl commented Jan 13, 2021 •

edited

Loading