Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.12 support #413

Merged
merged 1 commit into from
Jan 9, 2024
Merged

python 3.12 support #413

merged 1 commit into from
Jan 9, 2024

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Jan 9, 2024

Description

This satisfies: #216

@vprusso
Copy link
Owner

vprusso commented Jan 9, 2024

LGTM, @purva-thakre, anything to add before merging?

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cc1899) 98.0% compared to head (86433d4) 98.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #413   +/-   ##
======================================
  Coverage    98.0%   98.0%           
======================================
  Files         154     154           
  Lines        3053    3053           
  Branches      742     742           
======================================
  Hits         2994    2994           
  Misses         37      37           
  Partials       22      22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre
Copy link
Collaborator

LGTM too !

@purva-thakre purva-thakre merged commit 8973d77 into vprusso:master Jan 9, 2024
14 checks passed
@Bchass Bchass deleted the py3.12 branch January 11, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants