Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword MToon UV Rotation Animation spec #410

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Oct 4, 2022

Description

  • MToonのuvAnimationRotationSpeedFactor仕様について、文章をアップデートしました。
    文意・解釈は変わらず、書き方のみの変更です。
    glTF側で現在進行中の Clarify descriptions of rotation direction in KHR_texture_transform KhronosGroup/glTF#1624 に合わせた書き方に揃えていますが、
    当該PRがまだマージされていないので、これがマージされるのを待ちたいかも知れません。
  • MToonのUVアニメーション仕様のテストモデルとなる「VRMC_materials_mtoon UV Animation Test」をsamplesに追加しました。

0b5vr added 2 commits October 4, 2022 17:54
A model that is an example of the VRMC_materials_mtoon extension
We might want to wait until the merge of the PR on the KHR_texture_transform side.
I still have low confidence about the wording

KhronosGroup/glTF#1624
@0b5vr 0b5vr added the material label Oct 4, 2022
@0b5vr 0b5vr requested a review from Santarh October 4, 2022 09:33
@0b5vr 0b5vr self-assigned this Oct 4, 2022
@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 7, 2022

KhronosGroup/glTF#1624 は特にアップデート無いですね……
このままマージしてしまいましょうか。

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです

@0b5vr 0b5vr merged commit fa5ede2 into vrm-c:master Oct 7, 2022
@0b5vr 0b5vr deleted the reword-mtoon-uv-rotation branch October 7, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants