Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix listing of sample models README #413

Merged
merged 3 commits into from
Nov 1, 2022
Merged

docs: Fix listing of sample models README #413

merged 3 commits into from
Nov 1, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Oct 31, 2022

Description

samples/README.md の変更です。

  • Reword MToon UV Rotation Animation spec #410 で追加した VRMC_materials_mtoon_UV_Animation_Test がREADMEから漏れていたので、これを追加しました。
  • 各モデルのお名前の箇所、おそらくリンクがあるのが意図どおりと思いますので（私が意図を汲みきれておりませんでした）、これを追加しました。

@0b5vr 0b5vr requested review from ousttrue and Santarh October 31, 2022 11:53
@0b5vr 0b5vr self-assigned this Oct 31, 2022
@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 31, 2022

レビュー、 @ousttrue @Santarh の両方にアサインしましたが、いずれかで良いかと思います。

ousttrue
ousttrue approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@ousttrue ousttrue merged commit 2551d8d into vrm-c:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

@Santarh Santarh Awaiting requested review from Santarh

Assignees

@0b5vr 0b5vr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @ousttrue