Update sla.adoc #86
Merged
Update sla.adoc #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micro upgrade to our docs
wejdross
requested review from
Kidswiss and
TheBigLee
and removed request for
a team
Kidswiss
requested changes
Sep 6, 2023
| @@ -21,6 +21,8 @@ metadata: | |||
| namespace: <your-namespace> | |||
| spec: | |||
| parameters: | |||
| # instances must be either 2 or 3 when serviceLevel=guaranteed is set | |||
| instances: 2 | |||
There was a problem hiding this comment.
I would do it with a callout, like the other explanations in this yaml file.
Suggested change
| instances: 2 | |
| instances: 2 <1> |
and then put the explanation in the bottom:
<1> instances must be either 2 or 3 when serviceLevel=guaranteed is set
You need to increment the other callouts though. And then it will render nice explanations for the code snippet.
Kidswiss
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro upgrade to our docs