Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sla.adoc #86

Merged
merged 2 commits into from
Sep 6, 2023
+4 −2
Merged

Update sla.adoc #86

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e7bad
Update sla.adoc
wejdross Sep 6, 2023
c09efff
fixing docs
Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/modules/ROOT/pages/vshn-managed/postgresql/sla.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ metadata:
namespace: <your-namespace>
spec:
parameters:
# instances must be either 2 or 3 when serviceLevel=guaranteed is set
instances: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do it with a callout, like the other explanations in this yaml file.

Suggested change
instances: 2
instances: 2 <1>

and then put the explanation in the bottom:
<1> instances must be either 2 or 3 when serviceLevel=guaranteed is set

You need to increment the other callouts though. And then it will render nice explanations for the code snippet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied

service:
serviceLevel: guaranteed <1>
majorVersion: "15"
Expand Down