Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-for over reactive([]) regression #7973

Closed
skirtles-code opened this issue Mar 28, 2023 · 1 comment · Fixed by #7974
Closed

v-for over reactive([]) regression #7973

skirtles-code opened this issue Mar 28, 2023 · 1 comment · Fixed by #7974
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working regression

Comments

@skirtles-code
Copy link
Contributor

skirtles-code commented Mar 28, 2023 •
edited
Loading

Vue version

Latest main branch
The latest release, 3.3.0-alpha.5, doesn't have this problem
I believe this was introduced by #5752.

Link to minimal reproduction

https://sfc.vuejs.org/#eNp9kM9OwzAMxl/FymWdtDbiWnUITjwE4dB1bpexJpGTlEPVd8dpNrSBxM1/Pv9sf7N4da6aIopaNL4j7QJ4DNE9K6NHZynADIRtF/SEsEBPdoQN6zfKKNNZ41kf0HnY/8iK949t6vbRcG4NDLbYwqwMZGnloj8VT6xZlGlk3sr7OAk4uksbkDOA5qinNeDw1oCp7C3tlUgk0CYTlbjqAOZ5LcHC7HVSPjC5cIgh8FEv3UV3n0wa7N34m72NZVk+ROZLHlhiJ7JB5di66uytYQvXJ9W1wWfV+e1UY89SrsQpBOdrKX3fJePPvrI0SI4qiiboESv0Y3kg++WRGKzE7o4huTghlYTmiIT0H/OX9A83YdmmRSzfE52xBg==

Steps to reproduce

Click the button.

What is expected?

No error.

What is actually happening?

Error.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'el')

System Info

No response

Any additional comments?

It seems to be related to the use of reactive(). If I switch the example to use ref() everything works fine.
@skirtles-code skirtles-code mentioned this issue Mar 28, 2023
Merged
@skirtles-code skirtles-code changed the title v-for regression in 3.3.0-alpha.5 v-for over reactive([]) - regression in 3.3.0-alpha.5 Mar 28, 2023
@skirtles-code skirtles-code changed the title v-for over reactive([]) - regression in 3.3.0-alpha.5 v-for over reactive([]) Mar 28, 2023
@skirtles-code skirtles-code changed the title v-for over reactive([]) v-for over reactive([]) regression Mar 28, 2023
@sxzz sxzz added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression labels Mar 28, 2023
@sxzz
Copy link
Member

sxzz commented Mar 28, 2023

Will fix soon.

@sxzz sxzz added the 🐞 bug Something isn't working label Mar 28, 2023
sxzz added a commit that referenced this issue Mar 28, 2023
@sxzz
fix(compiler-core): check if expression is constant
3df3354 
closes #7973
@sxzz sxzz mentioned this issue Mar 28, 2023
Merged
yyx990803 pushed a commit that referenced this issue Mar 29, 2023
@sxzz
fix(compiler-core): check if expression is constant (#7974)
77686cf 
close #7973
IAmSSH pushed a commit to IAmSSH/core that referenced this issue May 14, 2023
@sxzz @IAmSSH
fix(compiler-core): check if expression is constant (vuejs#7974)
6017a66 
close vuejs#7973
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-core): check if expression is constant vuejs/core
2 participants
@sxzz @skirtles-code