feat(complier-sfc): add hoistStatic for <script setup>
#5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vuejs-coverage failed.
|
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sxzz
changed the title
script setup
|
If this feature is acceptable, I will add a Unit Test for it later. |
|
This is great. Let's add some tests for it |
|
I'm considering whether this feature is enabled by default, or is it an experimental feature and not enabled by default? |
|
@yyx990803 Added. |
sxzz
changed the title
script setup<script setup>
sxzz
changed the title
<script setup>hoistStatic for <script setup>
posva
reviewed
Aug 26, 2022
packages/compiler-sfc/__tests__/__snapshots__/compileScript.spec.ts.snap
Outdated
Show resolved
Hide resolved
antfu
approved these changes
Oct 3, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I think this may have introduced a regression: #7973. I'm not sure of the cause, but testing locally it seems to work fine prior to this being merged. |
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
- Support using literal constants in macros - fix useCssVars insert position edge case - fix non-literal-const enum hoisting close vuejs#5750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5750
Introduce a option
hoistStaticinscript.Only enables when there's only one
<script setup>(enabled by default)Fix these cases
_useCssVarsshould be put inside ofsetupBefore | After
enumshouldn't be hoistedBefore | After
Demo