Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): should not take unmount children fast path if not in optimized mode #5198

Closed
wants to merge 15 commits into from
Closed

fix(runtime-core): should not take unmount children fast path if not in optimized mode #5198

wants to merge 15 commits into from

Conversation

edison1105
Copy link
Member

close #5154

@edison1105 edison1105 added the need test The PR has missing test cases. label Jan 2, 2022
@edison1105 edison1105 changed the title fix(runtime-core): should not take unmount children fast path for v-once fix(runtime-core): should not take unmount children fast path if without patchFlag Jan 7, 2022
@edison1105 edison1105 removed the need test The PR has missing test cases. label Jan 7, 2022
@edison1105 edison1105 closed this Jan 7, 2022
@edison1105 edison1105 reopened this Jan 7, 2022
@edison1105 edison1105 changed the title fix(runtime-core): should not take unmount children fast path if without patchFlag fix(runtime-core): should not take unmount children fast path if dynamicChildren is empty Jan 7, 2022
@vercel
Copy link

vercel bot commented Jul 18, 2023

@edison1105 is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@edison1105 edison1105 changed the title fix(runtime-core): should not take unmount children fast path if dynamicChildren is empty fix(runtime-core): should not take unmount children fast path if not in optimized mode Jul 18, 2023
@edison1105 edison1105 marked this pull request as draft July 19, 2023 01:21
@edison1105 edison1105 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-once and "unmount callbacks", possible memory leak?
1 participant
@edison1105