-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v-once and "unmount callbacks", possible memory leak? #5154
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
🐞 bug
Something isn't working
Comments
yyx990803
added
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
🐞 bug
Something isn't working
labels
Dec 23, 2021
5 tasks
The UPD: a more obvious example of the bug. The unmount is not called as the result the global click listener is not removed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
🐞 bug
Something isn't working
Version
3.2.26
Reproduction link
codesandbox.io
Steps to reproduce
What is expected?
Console statements saying that the "OtherCmponent" is unmounted/destroyed are shown along with the "mounted" statements.
What is actually happening?
Only the mount statements are shown
This was behaving differently in vue2, as the "destroy callbacks" were called, see: https://codesandbox.io/s/lingering-water-j7g43
This might also be related to this external issue: intlify/vue-i18n#844 (I think I can see evidence of something similar with vue-router) and generally, it might introduce memory leaks when using Components that were not specifically written to account for the beforeUnmount/unmounted not being called.
Please do let me know if this is not an issue but just a documentation miss (is it specified somewhere or should it be?), or if this is just my misunderstanding.
The text was updated successfully, but these errors were encountered: